rpms/mplayer/devel .cvsignore, 1.12, 1.13 mplayer-snapshot.sh, 1.3, 1.4 mplayer.spec, 1.22, 1.23 sources, 1.13, 1.14 mplayer-cflags.patch, 1.1, NONE mplayer-manlinks.patch, 1.2, NONE mplayer-ppc-compile.patch, 1.1, NONE

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 21 October 2009 at 23:10, NicolasChauvet wrote:
> Author: kwizart
> 
> Update of /cvs/free/rpms/mplayer/devel
> In directory se02.es.rpmfusion.net:/tmp/cvs-serv25667/devel
> 
> Modified Files:
> 	.cvsignore mplayer-snapshot.sh mplayer.spec sources 
> Removed Files:
> 	mplayer-cflags.patch mplayer-manlinks.patch 
> 	mplayer-ppc-compile.patch 
> Log Message:
> - Update to snapshot 20091021
>   mplayer svn rev: 29776
>   ffmpeg : HEAD
>   dvdnav : HEAD

Ahem... why?

[...]
> Index: mplayer-snapshot.sh
> ===================================================================
> RCS file: /cvs/free/rpms/mplayer/devel/mplayer-snapshot.sh,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -r1.3 -r1.4
> --- mplayer-snapshot.sh	16 Oct 2008 20:03:52 -0000	1.3
> +++ mplayer-snapshot.sh	21 Oct 2009 21:10:53 -0000	1.4
> @@ -12,18 +12,25 @@
>  
>  unset CDPATH
>  pwd=$(pwd)
> -svn=$(date +%Y-%m-%d)
> +svn=20091021

Why are you changing the date format?

>  dirname=mplayer-export-$svn
> +mplayer_rev=29776
> +ffmpeg_rev=HEAD
> +dvdnav_rev=HEAD

This isn't right. ffmpeg_rev and dvdnav_rev should correspond to the date
of MPlayer checkout.

[...]
> @@ -190,12 +188,8 @@
>  %else
>  %setup -q -n MPlayer-%{version}%{pre}
>  %endif
> -%patch1 -p1 -b .ppc-compile
>  %patch2 -p1 -b .config
> -%patch3 -p1 -b .cflags
> -%patch8 -p1 -b .manlinks
> -%patch10 -p1 -b .qclp
> -%patch14 -p1 -b .nodvdcss
> +

Please don't add unnecessary empty lines.

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"