bsnes 0.051+

[Julian Sikorski]

W dniu 29.09.2009 15:16, Andrea Musuruane pisze:
> On Tue, Sep 29, 2009 at 1:37 PM, Julian Sikorski <belegdol at gmail.com> wrote:
>> as of 0.051, bsnes is now GPL. This is not the only change, however. It
>> also now requires an additional library [1] to support compressed ROM
>> images. The problem is that this library seems (at the first glance)
>> contain mostly duplicated code from rar, 7-zip and friends, albeit
>> modified. I have no skills nor time to try patching it up to use
>> system-wide libs, so I have no idea how to proceed. For now, I have
>> requested the latest bsnes build not to be pushed to stable, but it is
>> of course only temporary.
>> I have attached a preliminary spec file, which gets the job done. The
>> thing is whether we are willing to accept such a chunk of (at least
>> partially) duplicated code to save the ability of bsnes to use
>> compressed ROM images.
> 
> Anyway, This is what Fedora Packaging Guidelines say:
> https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
> 
> It is quite clear that a reviewer could not accept the package as it is. Sorry.
> 
> BTW have you checked that all the bundled library licenses are
> compatible with the GPL used by bsnes?
> 
> Bye,
> 
> Andrea.
> 
I only had a quick look, and the RAR code is the only problematic one,
but it seems that RAR support can be disabled. Does the fact that the
libsnesreader.so is dlopened and not linked to change anything here?
Also, unless somebody is willing to do the work to make this monster
acceptable for a Review, we have two options:
1. keep updating the emulator regardless of the missing compressed ROM
images support, or
2. stay at version 0.050 indefinitely

I'd go with option 1, maybe including a note in the readme explaining
why the support is missing and what can be done to help the situation.
What do you guys think?

Julian