[Bug 985] Review request: ProjectX-0.90.4.00-2

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=985


David Timms <dtimms at iinet.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #14 from David Timms <dtimms at iinet.net.au>  2010-08-01 17:13:29 ---
(In reply to comment #12)
> > Should at least include a correct upstream path
> 
> I didn't put any since there isn't any upstream path to the tar archive.  But
> I've added a comment on how the tar archive can be (re)made using a cvs and a
> tar command.  It includes the exact path to the CVS pserver.  Is this a good
> way to document where it comes from?
Yes, it's basically OK, but has an issue that it overwrites the archive of the
actual release version, because the file name is the same. That is something to
avoid; eg the resultant filename should include the %{_release} part, and hence
indicate it is different to the release filename. See:
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

Also, .cvsignore are left inside, along with a heap of empty directories (but
maybe they are used in the build process - i didn't notice).

You can make and include a script like:
http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code
shows.
An example: http://cvs.rpmfusion.org/viewvc/rpms/ffmpeg/devel/?root=free
ffmpeg-snapshot.sh
and include it as part of the package, eg: Source1 or whatever.


===== Is this the startup script ? 
cat > %buildroot%_bindir/projectx << EOF
#! /bin/bash
. /usr/share/java-utils/java-functions
MAIN_CLASS=net.sourceforge.dvb.projectx.common.Start
set_classpath %name commons-net jakarta-oro
run "\$@"
EOF
=====
I think it would be clearer to make this a source that sits in cvs, rather than
build time generating it. Any changes can then be easily diffed within cvs

=====build fails
+ echo 'Patch (ProjectX.sysjava.patch):'
Patch (ProjectX.sysjava.patch):
+ /bin/cat /home/davidt/rpmbuild/SOURCES/ProjectX.sysjava.patch
+ /usr/bin/patch -s -p0 --fuzz=0
1 out of 1 hunk FAILED -- saving rejects to file MANIFEST.MF.rej
error: Bad exit status from /var/tmp/rpm-tmp.RMmIat (%prep)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.RMmIat (%prep)

Does the patch need to be rediffed ? There was a change in fedora to use fuzz0,
and hence the patch needs to more closely match the source.

=====
Are you already sponsored in fedora or rpmfusion ?
What is your fas username ?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.