[Bug 1561] Review Request : lugaru - Third-person action game

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1561


Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org




--- Comment #1 from Xavier Bachelot <xavier at bachelot.org>  2010-12-24 03:13:46 ---
A couple comments :
- I'm not sure the version-release is right : I think it should be something
like 0-0.1.20101223hg275, as per
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
- The license applying to various part of the code/data is not clear, you
should at least clarify with a comment inside the spec but anyway, I think it
would be better to have 2 packages, one for the code and one for the datas.
- I'd prefer to have the files generated inside the spec as SourceX (desktop
file, launcher script, man page), it'll make the spec easier to read.
- You should replace %{_mandir}/man1/%{name}.1.gz with 
%{_mandir}/man1/%{name}.1.*, in case the compression method changes someday.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.