[Bug 1153] Review request: m2vmp2cut - MPEG2 frame accurate cutter

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1153


Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|3                           |4




--- Comment #8 from Andrea Musuruane <musuruan at gmail.com>  2010-12-24 14:55:26 ---
(In reply to comment #7)
> So THAT is how the rule is to be interpreted.  I took it as a minimum, and I
> was actually careful NOT to remove the optimization options that were there
> from the start.
> 
> But reading the guideline again, I see that even ADDING to optflags needs to be
> motivated.  And "upstreams chose to do so" isn't enough of a motivation in this
> case I guess.

If you call gcc but you are just linking and not compiling it is not necessary
to use the optflags. So, the part of the patch related to the makefile can be
safely removed IHMO.

Anyway, I trust you'll do this before importing to the repository.

This package is APPROVED!


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.