[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #90 from rc040203 at freenet.de  2010-02-08 05:08:52 ---
(In reply to comment #89)
> Is each diff supposed to be a separate patch, or are some of them grouped
> logically?
Each diff is a separate patch.

>  If you could tell me which one's are together and give a (rough)
> description I will also submit them upstream to the trac ticket.

The actually interesting part for us is this:

* configure.in: *FLAGS, configure-argument hacks.
Incremental patch against previous patches on configure.in.
Should probably be merged with its predecessors.


All other patches address more or less minor issues with xbmc, I tripped over
when repeatedly building xbmc:

* xbmc/cores/paplayer/GYMCodec/ym2612.h:
Clean up of a signed/unsigned char handling sloppiness.

* xbmc/cores/paplayer/MACDll/Makefile.in:
Remove -pedantic from CFLAGS. 
Passing -pedantic in a production SW's Makefile doesn't make any sense.

* xbmc/cores/paplayer/MACDll/Source/MACLib/Prepare.cpp:
Use <number>U instead of <number> for unsigned <number> constant initialization
to avoid potential C-dialect issues (Improve portability). GCC warns about the
original code to change behavior depending up --stdc=.. variant being used.
Actually, I'd assume the original code in xbmc to be dysfunctional. However as
this code is part of a codec of an exotic format (at least on Linux), I'd
assume potential issues caused by this code might have gotten away unnoticed so
far.

* xbmc/lib/libid3tag/libid3tag/metadata.c:
Add missing prototypes for free/malloc, ... etc.
Original code is non-posix compilant.

* xbmc/lib/libRTV/Makefile.in:
Remove -D__unix__. 
__unix__ is an internal system define, all unix-compilers (comprising linux)
internally define. It's a violation of POSIX to specify it on a compiler's
command line.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.