[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #11 from rc040203 at freenet.de  2010-01-03 08:58:27 ---
Some further remarks/comments:

* Could you explain this fragment from your spec:

%ifarch x86_64
CFLAGS="-I/usr/lib64/dbus-1.0/include -I/usr/lib64/glib-2.0/include" make
%else

AFAICT, dbus is being picked up by the toplevel configure script and propagated
correctly to the files trying to access dbus headers => IMO, these CFLAGS are
redundant and superfluous.

Proposal: Remove these CFLAGS.


* Silent make rules are harmful: Some cmake-based parts of the package are
compiled silently, hiding away the protentally broken compiler calls they are
using underneath 

[In this case, they indeed are broken - They are passing around bogus defines.
I haven't checked yet whether this is causing actual problems.]

Proposal: Use "make VERBOSE=1" instead of "make"


* Redundant "BR: mysql-libs"
BR: mysql-devel should be sufficient.

... more to come ...


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.