[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #12 from Rolf Fokkens <rolf.fokkens at online.nl>  2010-01-03 15:30:57 ---
Good points.

The reason for the ifarch's was a good one when I tried to make xbmc build on
Fedora 11, but apparently there's no reason anymore. So:

[rolf at home07 SPECS]$ diff -ruN xbmc.spec.sav xbmc.spec
--- xbmc.spec.sav       2010-01-03 11:00:15.027212350 +0100
+++ xbmc.spec   2010-01-03 15:28:14.446072042 +0100
@@ -48,7 +48,6 @@
 BuildRequires: freetype-devel
 BuildRequires: libXinerama-devel
 BuildRequires: fontconfig-devel
-BuildRequires: mysql-libs
 BuildRequires: mysql-devel
 BuildRequires: jasper-devel
 BuildRequires: faac-devel
@@ -152,18 +151,10 @@
   done

 %build
-CFLAGS="-I$PWD//xbmc/lib/cximage-6.0/jpeg/"
-
-%ifarch x86_64
-LDIR=lib64
-%else
-LDIR=lib
-%endif
-CFLAGS="-fPIC -I/usr/$LDIR/dbus-1.0/include -I/usr/$LDIR/glib-2.0/include"
-CFLAGS="$CFLAGS -I/usr/include/ffmpeg/"
+CLFAGS="-fPIC -I/usr/include/ffmpeg/"
 CXXFLAGS="$CFLAGS"
 LDFLAGS="-fPIC"
-LIBS="-L/usr/$LDIR/mysql $LIBS"
+LIBS="-L%{_libdir}/mysql $LIBS"
 export CFLAGS
 export CXXFLAGS
 export LDFLAGS
@@ -174,11 +165,7 @@
 export ASFLAGS=-fPIC
 %configure --enable-external-libraries --enable-goom

-%ifarch x86_64
-CFLAGS="-I/usr/lib64/dbus-1.0/include -I/usr/lib64/glib-2.0/include" make
-%else
-make 
-%endif
+make VERBOSE=1

 %install
 rm -rf $RPM_BUILD_ROOT
[rolf at home07 SPECS]$ 

Alex may include this in the next build.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.