[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #28 from Alex Lancaster <alexl at users.sourceforge.net>  2010-01-17 08:01:59 ---
(In reply to comment #17)

> * Package contains a patch backup:
> /usr/lib64/xbmc/system/python/spyce/spyce.py.spyce
> 
> Proposal: Don't use patch backups (I personally consider them to be harmful).

Removed "-b" for this patch at least.  Not sure about removing them all
completely at this point.  They do serve a role in documenting what the patch
is which is helpful when renumbering because they don't require copying
separate comments around.


> Proposal: Add 
> rm -f $RPM_BUILD_ROOT%{_libdir}/xbmc/visualisations/xbmc_vis.h
> to %install 
> (I thought this already had been in Rolf's original *.spec ?)

Fixed.

> * Building goom triggers this warning:

> The solution to this issue would be to either upgrade/patch
> xbmc/visualizations/Goom/goom2k4-0/missing to a newer version of "missing" or
> to extend "bootstrap" to be run inside of xbmc/visualizations/Goom/goom2k4-0
> (Dangerous!)

Not sure what the best thing would be to do here.  Perhaps upstream can be
convinced to fix this.

> * RPM_OPT_FLAGS are still not acknowledged correctly in all places.

OK, let me know if you have any patches that could fix this.

> * xbmc's webserver frequently dumps core on x86_64.

> * xbmc still applies local files from its local copies of zlib.
> [I am working on it - Patch to come soon.]

Applied your patch below.

> * I am not convinced about Rolf's "win patch".
> Instead, I am using this in %prep:
> ...

Implemented this in place of Rolf's version, seems to work for me.  I plan to
add a script with all this logic (removing binaries, unneeded bundled code and
any prohibited code) that modifies the upstream tarball and repacks it in the
next iteration which will reduce the SRPM size considerably.

> * /usr/bin/xbmc contains some magic to produce "verbose core dump logs".
> I am not sure, this logic is useful in general and on Fedora in particular
> (abrt already takes care about it), but I don't have a strong opinion on it.

Does abrt work with filing bugs on bugzillas for with 3rd party repos like RPM
Fusion?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.