[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #42 from Alex Lancaster <alexl at users.sourceforge.net>  2010-01-21 09:02:11 ---
OK, time to do a quick patch audit, Rolf and Ralf, could you clarify the
following points?  Thanks.

Rolf: is this necessary, it seems to add a single "-I ../jpeg", I thought that
xbmc is using the system libjpeg at this point, should it be submitted
upstream?
  Patch0: xbmc-9.11-a2-libjpeg.patch

Rolf: has this been submitted upstream, will this be fixed in the 10.x release?
 Patch1: xbmc-9.11-a2-gcc440.patch

This patch look for libdca, rather than libdts, there is already:
 http://xbmc.org/trac/ticket/8040 (although patch slightly different to this
one)
 Patch2: xbmc-9.11-b1-config.patch

Rolf, is this necessary if we remove dvdcss from source?
 Patch3: xbmc-9.11-b1-dvdlibs-external.patch

This had been submitted upstream: http://xbmc.org/trac/ticket/8026 (should be
in next release):
 Patch4: xbmc-9.11-use_cdio_system_headers_on_non_win32.patch 

I added next 3 patches to trac:  http://xbmc.org/trac/ticket/8590
 Patch5: xbmc-9.11-fix-Makefile.in.patch
 Patch6: xbmc-9.11-Makefile.include.in.diff
 Patch7: xbmc-9.11-xbmc.sh.diff

Rolf: could you clarify the purposes of the next 3 patches be submitted
upstream?  Remlibs appears to force using external libass:
 Patch8: xbmc-9.11-spyce.diff
 Patch9: xbmc-9.11-RandomNumberGenerators.hpp.diff
 Patch10: xbmc-9.11-remlibs.patch

Ralf this fixes GCC warning: partial backport to 9.11, will this be fixed in
next release?  Do we need to report upstream?
 Patch11: xbmc-9.11-changeset-26191.diff

This fixes problems with web server segfaulting on x86_64, I submitted 
http://xbmc.org/trac/ticket/8591
 Patch12: xbmc-9.11-GoAhead.diff


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.