[Bug 1321] Review request: libva - Video Acceleration (VA) API for Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1321


Hans de Goede <j.w.r.degoede at hhs.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #5 from Hans de Goede <j.w.r.degoede at hhs.nl>  2010-07-12 13:43:24 ---
Hi,

A few small remarks / questions / things to fix

1) Can we please rename the *package* to libva-freeworld, so that if / when
parts of libva show up in Fedora, it can be named libva there, and we can
include only some non free plugins (or so I hope) and drop the rest, Requiring
the new libva to ensure a smooth upgrade path.

2) I don't like the chosen versioning scheme, I would prefer
Version:        0.31.0
Release:        1.sds13%{?dist}

Which also seems to be more conform the guidelines:
http://fedoraproject.org/wiki/PackageNamingGuidelines#Non-Numeric_Version_in_Release
and you can then drop the %sver global, and the -n argument to %setup

3) this line:
%doc COPYING

Is present in all 3 %files section, as all sub-packages implicitly or
explicitly require the main package this should only be present in the main
%files

Thanks & Regards,

Hans


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.