[Bug 1278] Review Request: mpg123 - MPEG audio player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278





--- Comment #8 from Hans de Goede <j.w.r.degoede at hhs.nl>  2010-06-18 09:41:31 ---
(In reply to comment #2)
> * The packaging looks sane. I'm not an RPMFusion dev, so I can't approve this,
> however.  And one could argue about whether the stuff in the -plugins-extras
> package is worthwhile. It will have a very limited target group (if at all).
> 

Hi Michael,

Anyone who is a sponsered Fedora packager automatically is a rpmfusion packager
and can submit / review / maintain packages here. So if you're happy with the
package can you please add an approved comment, then I'll move forward with the
CVS procedure etc.

(In reply to comment #3)
> I suggest to use mpg123-libs instead of libmpg123. Internal libs for a program
> normally named xxx-libs except the program don't link with those shlibs.
> 

Hi Chen,

Upstream and various users of the libs refer to them as libmpg123, and that is
for example also what the pkgconfig is called.

(In reply to comment #6)
> ./configure show mpg123 support assembler level optimiztion for different CPUs,
> maybe those optimization should be enabled.
> 

When no options are given all assembly code gets compiled in and which one
to use gets determined runtime.

> I also suggest to add a --with-default-audio=pulse switch to %configure.

The alsa output works fine with the alsa pulseaudio plugin, and given that this
is a cmdline app using pulseaudio (which only runs under a gdm login) does not
necessarily make sense. Moreover pulseaudio upstream advices normal apps to use
libalsa together with the alsa pulseaudio plugin, so that they will work on non
pulseaudio using systems too.

Thanks & Regards,

Hans


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.