[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #132 from Alex Lancaster <alexl at users.sourceforge.net>  2010-03-06 09:20:35 ---
New version (-13), SRPM is in the process of being uploaded:

* Fri Mar  5 2010 Alex Lancaster <alexlan[AT]fedoraproject org> - 9.11-13
- Patches to add -lXext to LIBS (thanks Ralf Corsepius)
- Hack to work around ffmpeg sws_scale() incompatibility (thanks Ralf)
- Remove bundled boost, libportaudio, libglew and extra unused zlib
  header from tarball
- Call desktop-file-install as per review guidelines
- Make spyce files executable, quiets rpmlint

Spec: http://alexlan.fedorapeople.org/rpmfusion/xbmc.spec
SRPM: http://alexlan.fedorapeople.org/rpmfusion/xbmc-9.11-13.fc12.src.rpm

x86_64 binary:
http://alexlan.fedorapeople.org/rpmfusion/xbmc-9.11-13.fc12.x86_64.rpm

rpmlint ../RPMS/x86_64/xbmc-9.11-13.fc12.x86_64.rpm
../SRPMS/xbmc-9.11-13.fc12.src.rpm 
xbmc.x86_64: W: spelling-error %description -l en_US playlist -> play list,
play-list, playtime
xbmc.x86_64: W: spelling-error %description -l en_US slideshow -> sideshow,
slide show, slide-show
xbmc.x86_64: W: spelling-error %description -l en_US plugins -> plug ins,
plug-ins, plugging
xbmc.src: W: spelling-error %description -l en_US playlist -> play list,
play-list, playtime
xbmc.src: W: spelling-error %description -l en_US slideshow -> sideshow, slide
show, slide-show
xbmc.src: W: spelling-error %description -l en_US plugins -> plug ins,
plug-ins, plugging
xbmc.src: W: strange-permission xbmc-generate-tarball-xz.sh 0755
xbmc.src: W: invalid-url Source0: xbmc-9.11-patched.tar.xz
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

Some additional notes regarding review


> [  -   ] MUST: The package must meet the Packaging Guidelines

> There are loads of bundled libraries, some internal to the project and therefore no problem, but others are external libraries and really should be
packaged separately.  See previous ten or so comments.  For guidelines, se
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

Many have been split out and I have removed more bundled copies of libraries
and headers in -13, notably boost, libportaudio, libglew.  Some of the other
internal only libraries that are used either only by XBMC can probably stay
there, although we are developing a firm plan to work with upstream to split
them out.  There is only or two packages that are currently in Fedora that XBMC
could potentially use, one is libhdhomerunner, not sure if using the external
version is non-trivial.  Other packages like cmyth and cximage are probably
non-trivial because of modifications by XBMC or stagnant upstream (like cmyth),
and they aren't used by any other Fedora package as far as I am aware, so I
think for this round probably safe to leave in.

So for the next round, I'd like to get a sense from the reviewer of which
bundles are acceptable to remain in for the moment, as getting every last one
removed is not feasible for 9.11 at least since they may require non-trivial
amounts of modifications to XBMC to get XBMC to recognize or compile against
the "external" version.  In some cases, these have been fixed in SVN upstream
and waiting for 10.5 is likely to not be feasible either. 

> [  -   ] MUST: The package must be licensed with a Fedora approved license
>         and meet the Licensing Guidelines

> While the main package is GPLv2+, some bundled libraries have ...odd... licenses. As mentioned in earlier comments, we really need to do something about them, especially libGoAhead.

I think libGoAhead is the most problematic of them, I will try to remove it in
-14.  libhts as noted in reply from upstream in comment #122 is GPLv3+, so
should be OK to use with GPLv2+ code if I understand
https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix correctly, it
basically means that XBMC is then effectively GPLv3.

> [  -   ] MUST: The sources used to build the package must match the upstream 
>         source, as provided in the spec URL.

> The current source in the SRPM *doesn't* match that generated using xbmc-generate-tarball-xz.sh.  There are several directories in xbmc/lib that shouldn't be there.

Should be fixed in -13.

> [  ?   ] MUST: The spec file MUST handle locales properly. This is done by 
>         using the %find_lang macro. Using %{_datadir}/locale/* is strictly 
>         forbidden

> XBMC stores its language files as xml files.  I'm not sure how that affects this rule.

Nor I, not sure if this is that important.

> [ -   ] MUST: Packages containing GUI applications must include a
>          %{name}.desktop file, and that file must be properly installed with 
>          desktop-file-install in the %install section.

> The file is installed in the proper location, but I don't see desktop-file-install being run, which means it won't show up in the menus until the user logs out, and then in again (at least as far as I understand it).

Should be fixed in -13

> [  -   ] SHOULD: The reviewer should test that the package builds in mock. (Don't have a fast enough Internet connection).

Will attempt to try this, should work now in branched/F-13 I think with Ralf's
patches for the DSO and other linker changes.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.