[Bug 1122] Review request: mame - Multiple Arcade Machine Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1122





--- Comment #1 from Chen Lei <supercyper at 163.com>  2010-03-19 17:53:39 ---
Some comments:
1.
%global baseversion 0137
#global sourceupdate 4

%if 0%{?sourceupdate}
Version:        %{baseversion}u%{sourceupdate}
%else
Version:        %{baseversion}
%endif
Release:        1%{?dist}

#global sourceupdate 4 -> #global sourceupdate u4
Version:        0.%{baseversion}
Release:        1.{?sourceupdate}%{?dist}
Note:{?sourceupdate} should be added in release section as fedora naming
guideline, such as 0.137-2.u1.fc13
3.
%ifarch x86_64 ppc64-> %ifarch x86_64 ppc64 sparc64 s390
Also you can not define suffix64 in specfile by using wildcard instead.
install -pm 755 %{name}%{?suffix64}d %{buildroot}%{_bindir}
->install -pm 755 %{name}*d %{buildroot}%{_bindir}
install -pm 755 chdman jedutil ldplayer%{?suffix64} ldresample ldverify \->
install -pm 755 chdman jedutil ldplayer* ldresample ldverify \

4.
Source0->
http://www.aarongiles.com/mirror/releases/%{name}0137s.exe
5.
Patch0 not used in specfile
6.
Provides:       sdlmame = %{version}-%{release}
Obsoletes:      sdlmame < 0136-2
->
Provides:       sdlmame = %{baseversion}-%{release}
Obsoletes:      sdlmame < 0137-1
7.
duplicate file found in subpackage.
%doc docs/license.txt
%doc docs/license.txt
You should not rely all on rpmlint output.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.