[Bug 1122] Review request: mame - Multiple Arcade Machine Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1122





--- Comment #7 from Chen Lei <supercyper at 163.com>  2010-03-21 04:23:00 ---
(In reply to comment #6)
> Spec URL: http://homepage.hispeed.ch/belegdol/mame/mame.spec
> SRPM URL: http://homepage.hispeed.ch/belegdol/mame/mame-0.137-2.fc13.src.rpm
> 
> New release:
> - Changed the versioning scheme to include the dot
> - Changed the source URL to point to aarongiles.com mirror directly
> - Added missing application of the fortify patch
> - Added sparc64 and s390 to architectures getting suffix64
> - Removed duplicate license.txt
> 
> If we consider u versions as a post-release, the versioning scheme is even more
> valid:
> 
> Properly ordered simple versions. These are usually due to quick bugfix
> releases, such as openssl-0.9.6b or gkrellm-2.1.7a. As new versions come out,
> the non-numeric tag is properly incremented (e.g. openssl-0.9.6c) or the
> numeric version is increased and the non-numeric tag is dropped
> (openssl-0.9.7). In this case, the non-numeric characters are permitted in the
> Version: field.
> 
> Other files do not exist in /etc/mame at the moment, but if my memory serves me
> well, we added that subdir with XulChris in case somebody wants to put them
> there.
> 
> Please note that ui.bdc is commented out at this point. I'll check the
> licensing when/if it ever returns.
> 
> And no, I haven't touched EMBOSS, unfortunately. I have no idea how to do that,
> my coding skills are next to none. So, unless a co-maintainer steps up, I'm
> afraid I might need to orphan the package. It turned out to require much more
> work than I expected.
> 
The spec seems perfect except some minor problems.
1.OPT_FLAGS='%{optflags}' is useless.
You should export optflags in the %build section.
export CCOMFLAGS = "%{optflags}"
export CONLYFLAGS = "%{optflags}"
export CPPONLYFLAGS = "%{optflags}"
2.
Since Mame build with GCONF2, maybe you need some rpm scriptlets(I'm not sure
about this).
See 
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.