[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #167 from Alex Lancaster <alexl at users.sourceforge.net>  2010-03-28 19:05:24 ---
(In reply to comment #166)
> These patches are ready to push upstream AFAIK, but I think upstream may not
> appreciate the fact that it isn't integrated in automake/autoconf. It's just a
> straightforward way to make XBMC build on F12 using external hdhomerun.
> 
> I trust upstream improves the patches after being pushed, though the may also
> just reject them.

Ah, yes, looking at them again, it seems that your patch doesn't detect the
presence of the hdhomerun headers using autoconf.  Ideally it would detect the
headers and use them if present and fallback to using the internal one if not
present, at the moment you simply remove the ability to use the internal one. 
This would necessitate adding corresponding --enable-hdhomerun in configure.in,
I wonder if you'd be willing to emulate how it is done for other libraries like
ffmpeg.   A patch like stands a better chance of being accepted upstream
because it wouldn't affect the default behaviour.  

Also now that I look at them, it seems that a couple of your other patches
could be modified in a similar way, specifically
xbmc-9.11-b1-dvdlibs-external.patch and xbmc-9.11-remlibass.patch, since they
both remove internal functionality rather than conditionally detect it.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.