[Bug 993] Review request: openshot - GNOME Non-linear video editor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=993





--- Comment #49 from Richard <hobbes1069 at gmail.com>  2010-10-21 14:57:26 ---
(In reply to comment #48)
> (In reply to comment #47)
> > I was able to build the install rpm cleanly and install it but had a couple of
> > questions.
> > 
> > 1. Should the package be GPG signed by RPMFusion yet? I had to --nogpgcheck to
> > get yum to install.
> Packages only get signed by RPM Fusion after they have been accepted into and
> built on the RPM Fusion builders. Hence --nogpgcheck is required while 
> developing the package.

That makes sense, I just wanted to check.

> > 2. I did a yum deplist on the resultant package and noticed it didn't list
> > "mlt-melt" or "frei0r-plugins" as dependencies. 
> 
> Are you testing with Elliott's patches, updated spec and newer upstream version?

I downloaded both patches and the spec from this bug report. I didn't see a
link for the 1.2.2 source RPM so I downloaded it from the openshot website. I
looked through the .spec file and didn't see any reference to mtl-melt (the
package) or frei0r-plugins. 

> While successful running is important, more important is that the packaging
> guidelines are followed - that is the point of the review - I'm encouraging you
> to take a look at the spec, and run through the packaging guidelines, to decide
> whether the spec passes, fails or you can't tell for each point in the spec.

I did review the links but there was a LOT of info on them I just haven't had
time to go through line by line. It may be this weekend before I do. 


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.