[Bug 993] Review request: openshot - GNOME Non-linear video editor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=993





--- Comment #52 from Richard <hobbes1069 at gmail.com>  2010-10-25 15:34:11 ---
(In reply to comment #51)
> Other than the missing dependencies the only two things that I can tell the
> package MIGHT be violating is:
> 
> - The spec file MUST handle locales properly. This is done by using the
> %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

Having slept on it and looking again there it is not using the %find_lang macro
but it's not using %{_datadir}/locale/* either. It's using some shell script. I
don't know if this is necessary since it's python based or for some other
reason but the locale files are definitely installed but under
"/usr/lib/python2.6/site-packages/openshot/locale/*".

> - Permissions on files must be set properly. Executables should be set with
> executable permissions, for example. Every %files section must include a
> %defattr(...) line. 

I don't know why I didn't see it the first time but the spec file is indeed
using the %defattr macro.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.