[Bug 1845] Review request: miro - Internet TV Player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845





--- Comment #26 from Michel Alexandre Salim <michel+rpmf at sylvestre.me>  2011-08-02 20:39:20 ---
(In reply to comment #25)
> (In reply to comment #24)
> > (In reply to comment #22)
> > > You also need to fix the build flags ( does it need to duplicate the flags 3
> > > times?).
> > > 
> > It doesn't, no. Looks like an upstream bug, but I'll try and track it down.
> 
> Remember, that was an excerpt from a python build, not miro...
>
That's due to the -DNDEBUG fix I mentioned; while not clobbering the built-in
settings, the side effect is that some compiler settings are duplicated.

The same thing is affecting Miro, actually; when Pyrex is used, it picks up the
CFLAGS *and* the compiler flags used to compile Python. But it's harmless,
anyway.

Looking into the CFLAGS have made me realize, though, that miro-segmenter was
being built without CFLAGS (because setup.py invokes the compiler manually,
since miro-segmenter is not a module, and didn't pass the proper parameters).
I've patched it in -4, and submitted it to upstream:

  http://bugzilla.pculture.org/show_bug.cgi?id=18027

> As far as the review goes, I can start, but I'd really like to see at least a
> patch for the reference counting bug...

Fair enough. And good thing you did test on F-14! That *would* take some time,
though.

Spec: http://salimma.fedorapeople.org/specs/media/miro.spec
SRPM: http://salimma.fedorapeople.org/specs/media/miro-4.0.2.1-4.fc15.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.