[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036

--- Comment #14 from Alex Lancaster <alexl at users.sourceforge.net> 2011-12-10 21:12:40 CET ---
(In reply to comment #13)
> (In reply to comment #7)
> > Does this Require or BuildRequire chromaprint from Fedora?  If so, it should
> > probably be added to the .spec.
> 
> Well, it IS chromaprint, except we're deleting all the library parts. From what
> Kevin said I think don't worry about it and let it find chromaprint through a
> soname dependency?

Yes, if fpcalc dynamically links to libraries in the main Fedora chromaprint
package, then no need to include the Requires, as auto requires will do it for
us.  This is a similar situation as the picard-freeworld package that builds
from the same tarball as the Fedora picard package that I both maintain. 
picard-freeworld adds a single .so to main picard Fedora package, except that
in that case, the .so file (it's essentially a plugin) doesn't link to anything
in the main Fedora package, so we need a manual "Requires" on picard, and I
make the picard-freeworld Require == %{version} because in this case, there are
possible API issues if it isn't installed with at least the same major version
of picard.   (This also means that the release tag doesn't necessarily need to
match, meaning that packaging fixes for either package can be pushed
independently).   I am also very careful to co-ordinate the pushes the
Fedora/RPM Fusion packages at the same time (I file a bug here to prevent
pushes to stable of picard-freeworld until corresponding Fedora picard has been
pushed) and this has worked pretty well, generally there's at most a few hours
when the deps might be broken. 

> Also, I was thinking it would be easier to cherry-pick the binary and install
> it manually than to go through a normal "mark install" and delete all the stuff we don't want. Same end result though.

Either works for me.    We do the latter in picard-freeworld:

http://cvs.rpmfusion.org/viewvc/rpms/picard-freeworld/devel/picard-freeworld.spec?revision=1.14&root=free&view=markup

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.