[Bug 2054] Review request: OCE - OpenCASCADE Community Edition

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2054

--- Comment #1 from Dan Horák <dan at danny.cz> 2011-12-11 19:14:43 CET ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK    source files match upstream:
        9729eba9255955051da361e6060c514b3e78b9bc 
tpaviot-oce-OCE-0.7.0-0-ga384024.tar.gz
OK    package meets naming and versioning guidelines.
BAD    specfile is properly named, is cleanly written and uses macros
consistently.
OK    dist tag is present.
OK    license field matches the actual license.
OK    license is open source-compatible, but non-free. License text included in
package.
OK*    latest version is being packaged.
OK    BuildRequires are proper.
OK*    compiler flags are appropriate.
OK    package builds in mock (Rawhide/x86_64).
OK    debuginfo package looks complete.
OK*    rpmlint is silent.
OK    final provides and requires look sane.
N/A    %check is present and all tests pass.
OK    shared libraries are added to the regular linker search paths, scriptlets
present.
OK    owns the directories it creates.
OK    doesn't own any directories it shouldn't.
OK    no duplicates in %files.
OK    file permissions are appropriate.
OK    correct scriptlets present.
OK    code, not content.
OK    documentation is small, so no -docs subpackage is necessary.
OK    %docs are not necessary for the proper functioning of the package.
OK    headers in devel subpackage.
OK    no pkgconfig files.
OK    no libtool .la droppings.
OK    library with a GUI app, desktop file installed.

- mixed use of %{buildroot} and $RPM_BUILD_ROOT (in desktop-file-install)
- new version was tagged today
- OCE overrides Fedora's -O2 to -O3, IMHO we should prefer the -O2, seems to be
connected to the "build type" Release vs. RelWithDebInfo (I'd use this) vs. ...
- rpmlint complains a bit
OCE.src: W: invalid-license Open CASCADE Technology Public License
OCE-debuginfo.x86_64: W: invalid-license Open CASCADE Technology Public License
OCE-foundation.x86_64: W: invalid-license Open CASCADE Technology Public
License
OCE-visualization.x86_64: W: invalid-license Open CASCADE Technology Public
License
OCE-draw.x86_64: W: invalid-license Open CASCADE Technology Public License
OCE-ocaf.x86_64: W: invalid-license Open CASCADE Technology Public License
OCE-devel.x86_64: W: invalid-license Open CASCADE Technology Public License
OCE-modeling.x86_64: W: invalid-license Open CASCADE Technology Public License
    => is OK

OCE.src: W: invalid-url Source0: tpaviot-oce-OCE-0.7.0-0-ga384024.tar.gz
    => OK because github

OCE-visualization.x86_64: W: shared-lib-calls-exit
/usr/lib64/libTKService.so.1.0.0 exit at GLIBC_2.2.5
OCE-visualization.x86_64: W: shared-lib-calls-exit
/usr/lib64/libTKOpenGl.so.1.0.0 exit at GLIBC_2.2.5
OCE-foundation.x86_64: W: shared-lib-calls-exit
/usr/lib64/libTKAdvTools.so.1.0.0 exit at GLIBC_2.2.5
OCE-foundation.x86_64: W: shared-lib-calls-exit /usr/lib64/libTKernel.so.1.0.0
exit at GLIBC_2.2.5
    => you can't do probably nothing with this

OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/tdoc 0644L /bin/sh
OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/test2xl 0644L /bin/sh
OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/idoc 0644L /bin/sh
OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/vmdltest 0644L /bin/sh
OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/demo 0644L /bin/csh
OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/mdltest 0644L /bin/sh
OCE-foundation.x86_64: E: non-executable-script
/usr/share/oce-0.7.0/src/DrawResources/mkdoc 0644L /bin/csh
    => do the files need to be installed at all?

OCE-devel.x86_64: W: no-dependency-on OCE/OCE-libs/libOCE
    => it depends on all the library subpackages

OCE-devel.x86_64: E: zero-length /usr/include/oce/MeshVS_MeshPrsBuilder.lxx
OCE-devel.x86_64: E: zero-length /usr/include/oce/AppBlend_Line.lxx
    => bug or feature?

OCE-visualization.x86_64: W: no-documentation
OCE-ocaf.x86_64: W: no-documentation
OCE-modeling.x86_64: W: no-documentation
    => developer documentation is removed in OCE

many unused-direct-shlib-dependency warnings on installed packages => maybe
using -Wl,--as-needed could solve it

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.