[Bug 2101] New: Review request: vbam - Gameboy Advance Emulator combining features of all VBA forks

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2101

             Bug #: 2101
           Summary: Review request: vbam - Gameboy Advance Emulator
                    combining features of all VBA forks
    Classification: Unclassified
           Product: Package Reviews
           Version: Current
          Platform: All
        OS/Version: GNU/Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Review Request
        AssignedTo: rpmfusion-package-review at rpmfusion.org
        ReportedBy: alexjnewt at hotmail.com
                CC: rpmfusion-package-review at rpmfusion.org


I'm already submitted this under a different package name but I changed the
name to something more suitable, thus I closed the other request and opened
this.

VBA-M is a fork from the now inactive VisualBoy Advance project, with goals to 
improve the compatibility and features of the emulator with: Improved Save 
Handling, Improved Archive Support, Improved Input Capabilities, New built-in 
Pixel Filters, KEGA Fusion Filter Plugin Support, Blargg's GB_APU, UPS Patch 
support, and JoyBus support.

Why it's not in Fedora: Emulators of video game systems seem to have legal
problems, which is not a new story for such applications, thus this excluded
from the fedora repos.

This package is already posted in the Wishlist by the way (under
VisualBoyAdvance Merge (VBA-M)), and is licensed as FOSS (GPL2). This is my
second RPM Fusion package, the first of which has yet to be accepted
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098). As well, I would assume I
would want a sponsor for this.

I left a bunch of comments in the SPEC file for easer review. Note that this is
a pre-release, no stable versions exist, though this release is very stable (RC
quality). Also note that there is a newer pre-lease than this (1.8.0.1042), I'm
currently trying to figure out how to build it without errors (has a SVN Error
stating it's not a working copy).

SPEC URL:
http://dl.dropbox.com/u/42480493/vbam.spec
SOURCE RPM URL: (though f16, should be distribution agnostic)
http://dl.dropbox.com/u/42480493/vbam-1.8.0.1001-1.fc16.src.rpm


RPMLINT WARNINGS:

Gameboy is not in the dictionary, thus this error is expected:
vbam.x86_64: W: spelling-error Summary(en_US) Gameboy -> Game boy,
Game-boy, Homeboy

I'm pretty sure man pages are optional, and I don't think they exist for vba-m,
so I ignored these:
vbam.x86_64: W: no-manual-page-for-binary gvbam
vbam.x86_64: W: no-manual-page-for-binary vbam

I was unsure if I should add a patch for this or ignore it, it functions just
fine with the error:
vbam.x86_64: E: invalid-desktopfile /usr/share/applications/gvbam.desktop
value "Application;Game;Emulator;GTK" for string list key "Categories" in group
"Desktop Entry" does not have a semicolon (';') as trailing character

the source rpm only gives the dictionary warning

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.