[Bug 1829] Review request: deadbeef-0.5.1 - A music player with *.cue support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829


David Timms <dtimms at iinet.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtimms at iinet.net.au




--- Comment #4 from David Timms <dtimms at iinet.net.au>  2011-07-01 15:35:08 ---
Some things to fix:
  whitespace: spec should use white space consistently.
- This means always use space or always tab for indentation.
- Also, remove trailing spaces and tabs from all lines.
- Looking at other specs, you'll notice that %files section do not have the
lines indented.
- take a look at the spec with an editor that can show whitespace:
yum install meld
meld deadbeef.spec.orig deadbeef.spec

- I think we are supposed to avoid ".la droppings" (see the fedora guidelines),
and hence shouldn't be packaging them.

- an rpm spec changelog should indicate changes only to the packaging, not to
the upstream application/program. It also has a standard no indent format, and
requires the change author's email.
eg: (from guidelines, 1 of 3 acceptable formats):
* Fri Jun 23 2006 Jesse Keating <jkeating at redhat.com> - 0.6-4
- fix the link syntax.
- moved .h devel files to -devel package.
- updated to upstream release 0.6.

- the upstream changelog lines could be included in a separate changelog file
that gests installed as part of the install.

- the sourceurl must point to a direct download. sourceforge files have such a
url that is required to be used.

- the warnings with desktop files do need to be taken care of. They don't
appear to be in the %files list, and they are using invalid group. It doesn't
look like desktop-file-install is being used.

- reduce lines to 80 chars max to assist readability.

- add multiple BuildRequires/Requires lines, with preferably one, and at most a
few related items, rather than placing all items on the same line.

- also, you shouldn't add requires that rpmbuild picks up automatically (try to
mock build without them to see if rpms succeeds).

- %{_defaultdocdir}/ items should probably be %doc

- %files:  you can add a directory, and it will include all files and subdirs

- are any the libs (.so) duplicates of fedora/rpm fusion supplied libs ?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.