[Bug 1829] Review request: deadbeef-0.5.1 - A music player with *.cue support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829





--- Comment #11 from Michael Schwendt <mschwendt at gmail.com>  2011-07-03 21:10:02 ---
Smaller but no correct yet.


> %{_defaultdocdir}/deadbeef
> %exclude %{_defaultdocdir}/deadbeef/*

What are these two lines supposed to achieve?
Sometimes comments in the spec file could do wonders. ;)


> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

As pointed out before, these two are not needed, because the package doesn't
store any library in run-timer linker's search path.


> %{_datadir}/applications/deadbeef.desktop

https://fedoraproject.org/wiki/Packaging/Guidelines#desktop
Notice section "desktop-file-install usage".


> %{_datadir}/deadbeef
> %{_libdir}/deadbeef

Note that spec files are much more comprehensible, if you add a trailing slash
to directories to distinguish them from single files. E.g.

%{_datadir}/deadbeef/
%{_libdir}/deadbeef/

but:

%{_bindir}/deadbeef


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.