[Bug 1829] Review request: deadbeef-0.5.1 - A music player with *.cue support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829





--- Comment #15 from David Timms <dtimms at iinet.net.au>  2011-07-04 23:45:58 ---
(In reply to comment #13)
> Some more fixes and new errors from rpmlint
> >> deadbeef.i686: W: incoherent-version-in-changelog 0.5.1-2 ['0.5.1-1.fc15', '0.5.1-1']

This indicates that the spec version/release was bumped, but it does not match
the latest changelog entry. Remember, changelog indicates what changed with the
package, rather than the upstream source, and hence must be added to for each
change you make to the spec.

> >> deadbeef.src:126: W: mixed-use-of-spaces-and-tabs (spaces: line 118, tab: line 126)
Easy fix ;-) tells you what line the problem is. Take a look with an editor
that shows whitespace as visible chars (eg like meld).

Regarding bundled libraries:
If you have a think about the way the source code works, do you think it would
be possible to include certain make/build parameters to the build environment
that would allow a packager to choose whether to use bundled or system
libraries ?

This would allow a custom build to include the bundled version, while the
Fedora (and other distro) packaging can use the system libraries.

Michael might be able to make more suggestions of how to go about it (I do not
have experience in this area).


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.