[Bug 1539] Review request: pithos - A Pandora client for the GNOME Desktop

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1539


Ken Dreyer <ktdreyer at ktdreyer.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktdreyer at ktdreyer.com




--- Comment #6 from Ken Dreyer <ktdreyer at ktdreyer.com>  2011-07-11 17:50:31 ---
Here is my review. Please see the bottom for suggestions.

[ yes ] rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.

$ rpmlint *.rpm
pithos.noarch: W: incoherent-version-in-changelog 0.3.10 ['0.3.10-1.fc14',
'0.3.10-1']
pithos.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/pithos/pylast.py
pithos.noarch: W: no-manual-page-for-binary pithos
pithos.src:9: W: macro-in-comment %{version}
pithos.src:10: W: macro-in-comment %{version}
pithos.src:10: W: macro-in-comment %{version}
pithos.src: W: invalid-url Source0: pithos-0.3.10.tar.bz2
2 packages and 0 specfiles checked; 1 errors, 6 warnings.


[ yes ] The package must be named according to the Package Naming Guidelines .
[ yes ] The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[ yes ] The package must meet the Packaging Guidelines .
[ yes ] The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.

Package is GPLv3.

[ yes ] The License field in the package spec file must match the actual
license.
[ n/a ] If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
[ yes ] The spec file must be written in American English.
[ yes ] The spec file for the package MUST be legible.
[     ] The sources used to build the package must match the upstream source,
as provided in the spec URL.

Posted SRPM: 
Upstream tarball: 

[ yes ] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[ n/a ] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[ yes ] All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ n/a ] The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ n/a ] Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[ no ] Packages must NOT bundle copies of system libraries.

Bundling pylast, http://code.google.com/p/pylast/.

[ n/a ] If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ yes ] A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[ yes ] A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
[ yes ] Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[ yes ] Each package must consistently use macros.
[ yes ] The package must contain code, or permissable content.
[ n/a ] Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
[ yes ] If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
[ n/a ] Header files must be in a -devel package.
[ n/a ] Static libraries must be in a -static package.
[ n/a ] If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
[ n/a ] In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[ n/a ] Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[ yes ] Packages containing GUI applications must include a %{name}.desktop
file

But see recommendations below

[ yes ] Packages must not own files or directories already owned by other
packages. 
[ yes ] All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
Items marked as SHOULD are things that the package (or reviewer) SHOULD do, but
is not required to do.

[ no ] If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it. 
[ no ] The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
[ yes ] The reviewer should test that the package builds in mock.

Mocked on F14.

[ yes ] The package should compile and build into binary rpms on all supported
architectures.
[ yes ] The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.

Tested on F14, works well.

[ n/a ] If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity.
[ n/a ] Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
[ n/a ] The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
[ no ] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[ no  ] your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.


----------------------------
I have a few suggestions:

Please include the release field in your changelog. Eg. "0.3.10-1".

Please unbundle pylast and Require: that package instead.

--add-only-show-in=GNOME means that the menu entry doesn't show up in Xfce.
Recommend that you remove this line.

Desktop icon is missing.  data/icons/scalable/apps/pithos.svg should be
installed into /usr/share/icons/hicolor/scalable/apps/ . I guess you could do
this manually, but shouldn't the build script be doing this for you?

Icon is missing in "About" dialog.  data/ui/AboutPithosDialog.ui references
"../media/icon.svg", but there's only a PNG file there. Not sure if this is a
packaging bug here, or a bug upstream.

You can remove %defattr if you don't plan to support RHEL4.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.