[Bug 1539] Review request: pithos - A Pandora client for the GNOME Desktop

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1539

--- Comment #12 from Richard <hobbes1069 at gmail.com> 2011-11-11 15:50:41 CET ---
I'm assuming this if for F16+? I tried to build under F15 but it failed. It was
not able to import a local module, which is strange.

Is the version of python that different in F16?

Also, you need to use desktop-file-install to correct the desktop file[1]:

+ desktop-file-install --delete-original
--dir=/builddir/build/BUILDROOT/pithos-0.3.13-2.fc16.x86_64/usr/share/applications
pithos.desktop
/builddir/build/BUILDROOT/pithos-0.3.13-2.fc16.x86_64/usr/share/applications/pithos.desktop:
error: (will be fatal in the future): value "GNOME" in key "Categories" in
group "Desktop Entry" requires another category to be present among the
following categories: GTK

Perhaps it needs --add-category="GTK" ??? 

I would look through other .desktop files you have installed and see what makes
sense.

Other than that, I don't see any issues. I think you're about ready for a full
review.

Richard

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.