[Bug 1845] Review request: miro - Internet TV Player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845


Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #30 from Richard <hobbes1069 at gmail.com>  2011-10-04 18:23:34 ---
Ok, last spec review before doing a full review:

1. As far as obsoleting the Fedora version of miro, the version and release
should probably be set statically at the "cutover" point instead of a variable,
which I think will cause it to obsolete itself on the next RPM Fusion release.

2. I don't think you need the "-n miro-%{version}" in %setup since it defaults
to "%{name}-%{version}".

3. Don't need "rm -rf %{buildroot} in %install unless your planning on
supporting EL5.

4. Don't need "%defattr(..." in %files unless building for EL5.

5. I don't think we need the "%if 0%{?fedora} >= 9" since there's no
expectation of this ever being build for Fedora 9.

Don't worry about posting a new package just yet. I'll go ahead and make the
changes on my end and make sure I didn't break anything. 

Richard


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.