[Bug 1845] Review request: miro - Internet TV Player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845





--- Comment #32 from Richard <hobbes1069 at gmail.com>  2011-10-04 22:37:00 ---
+: OK
-: must be fixed
=: should be fixed (at your discretion)
?: Question or clairification needed
N: not applicable

MUST:
[+] rpmlint output: shown in comment: 
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license: GPLv2+ with exceptions.
[+] license field matches the actual license.
[+] license file is included in %doc: license.txt
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sum matches (69b1195296651c006f75f28d5b010365)
[+] package builds on at least one primary arch: Tested F15 x86_64
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[N] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[N] no relocatable packages
[+] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[N] header files in -devel
[N] static libraries in -static
[N] .so in -devel
[N] -devel requires main package
[+] package contains no libtool archives
[+] package contains a desktop file, uses desktop-file-install/validate
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8

SHOULD:
[+] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock
[+] package builds on all supported arches
[+] package functions as described: Tested basic usage.
[+] sane scriptlets
[N] subpackages require the main package
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[-] package contains man pages for binaries/scripts

Ok, to sum up, everything looks good as long as:
- the "private shared object provides" are taken care of 
- The license field is updated to something like, "GPLv2+, except lib/ which
includes MIT and BSD licensed files."

If you use the licensecheck tool it will let you know that some of the files in
the lib/ directory are not GPLv2+ licensed. 

Other non-critical problems:
- /usr/bin/miro-segmenter does not have a man page or any documentation that I
can find.
- It looks like miro 4.0.3 has been releaed. Might as well update it now.

I had to update the spec file to get things building so I can give you mine if
you want or you can update it yourself. After these are cleared up I think
you'll be good to go.

Richard


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.