[Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975


Nicolas Chauvet <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://deogracia.free.fr/RPM|
                   |S/arista.spec               |
                   |http://deogracia.free.fr/RPM|
                   |S/arista-0.9.7-             |
                   |2.fc15.src.rpm              |
            Summary|"Review request: arista - An|Review request: arista - An
                   |easy to use multimedia      |easy to use multimedia
                   |transcoder for the GNOME    |transcoder for the GNOME
                   |Desktop                     |Desktop




--- Comment #4 from Nicolas Chauvet <kwizart at gmail.com>  2011-10-09 12:49:03 ---
SPEC: http://deogracia.free.fr/RPMS/arista.spec 
SRPM: http://deogracia.free.fr/RPMS/arista-0.9.7-2.fc15.src.rpm
Summary: An easy to use multimedia transcoder for the GNOME Desktop

Thx for your submission 

For forgot to mention why this package cannot be in fedora ?

I expect it will be because of the gstreamer-ffmpeg and others requirements,
but please remind that adding gstreamer-plugins-bad-nonfree will make this
package fall into the nonfree section.
For the same reason that we should avoid package in the nonfree section, I
think this package should also be eligible for fedora by removing some explicit
requirements.
This need to be tested in order to prove a basic usability such as transcoding
from theora to webm, but also to fail with a message telling the user that some
codec are missing (and eventually to install them if the RPM Fusion repository
is installed).



Other comments:
- Please use english for comments
- duplicate license field for the subpackage:
License:        LGPLv2+
The main and subpackage use the same license, please keep only the main license
field.
- CFLAGS="$RPM_OPT_FLAGS" %{__python} for noarch package is not needed, please
remove.
- BR on fdupes is dubious. Files listed twice in a spec file are detected
automatically nowadays. I don't see the point of this check.
Also as the macro doesn't even exist , it should probably be conditionalised:
%{?fdupes:%fdupes %{buildroot}%{_datadir}/arista/}


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.