[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992


Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org




--- Comment #1 from Xavier Bachelot <xavier at bachelot.org>  2011-10-19 16:45:06 ---
I'm not a sponsor so this is an informal review. Here are a couple comments :

- Source files are not valid, you should create an svn snapshot from upstream
source code and work from there. See
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control

- You don't need the BuildRoot tag, the "rm -rf %{buildroot}" at the beginning
of the %prep section and the whole %clean section unless you want to build for
EL5.
See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 

- The %defattr line in the %files section is not needed unless you want to
build for EL5.
See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

- The install of the winetricks file could be made simpler :
install -Dp -m0755 %SOURCE0 %{buildroot}%{_bindir}/winetricks

- Same for the manpage. Also no need to gzip it, rpmbuild will take care of
that.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.