[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992





--- Comment #3 from Xavier Bachelot <xavier at bachelot.org>  2011-10-20 12:25:07 ---
The release tag is not correct. It should be 2.20110629svn666. See
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

You'd rather use svn export to generate the tarball. Also, you could add
something like "%global svn_changeset 666" and use it in the spec file, rather
than hardcoding the changeset.

The %attr for the man page is not needed in the %file section.
Also, replace the .gz by .*, in case the compression method for manpages
changes someday.

As winetricks provides a GUI, you must install a desktop file. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

Can you explain the need for the manual Requires: ? Especially coreutils,
xdg-utils and perl.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.