[Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992





--- Comment #5 from T.C. Hollingsworth <tc at tchol.org>  2011-10-20 14:21:30 ---

(In reply to comment #3)
> The release tag is not correct. It should be 2.20110629svn666. See
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

It's my understanding that listing the snapshot in the release is only required
for pre- and post-release snapshots.  This is an official stable release; we're
just using SVN since upstream doesn't provide proper tarballs.

> You'd rather use svn export to generate the tarball. Also, you could add
> something like "%global svn_changeset 666" and use it in the spec file, rather
> than hardcoding the changeset.

Fixed.

> The %attr for the man page is not needed in the %file section.

Strangely, yesterday rpmlint gave a "spurious-executable-perm" error on the
manpage, but it isn't today.  (F16 bug perhaps?)  Fixed.

> Also, replace the .gz by .*, in case the compression method for manpages
> changes someday.
> 
> As winetricks provides a GUI, you must install a desktop file. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

Fixed these two also.

> Can you explain the need for the manual Requires: ? Especially coreutils,
> xdg-utils and perl.

RPM's automatic dependency generator picks up nothing but /bin/sh so it seems I
have to specify everything:

$ rpm -qpR winetricks-20110629-2.noexplicitrequires.fc16.noarch.rpm 
/bin/sh  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

Regarding the specific packages you mentioned:  coreutils is needed for
sha1sum, xdg-utils is needed because it uses "xdg-open", and Perl is used by
one of the "tricks" to edit config files.

(In reply to comment #4)
> rpmlint on the srpm is not clean :

Also fixed.

--

Spec:  http://tchol.org/rpmfusion/winetricks.spec
SRPM:  http://tchol.org/rpmfusion/winetricks-20110629-3.fc16.src.rpm

$ rpmlint winetricks.spec
winetricks.spec: W: invalid-url Source0: winetricks-20110629.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint winetricks-20110629-3.fc16.src.rpm 
winetricks.src: W: invalid-url Source0: winetricks-20110629.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint winetricks-20110629-3.fc16.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.