[Bug 1975] Review request: arista - An easy to use multimedia transcoder for the GNOME Desktop

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1975


Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hobbes1069 at gmail.com




--- Comment #9 from Richard <hobbes1069 at gmail.com>  2011-10-22 20:20:44 ---
(In reply to comment #8)
> Hi guys,
> 
> I've updated the files.
> Could someone check up again please ?

Ok, a couple of observations.

1. You only need one of the macros at the top of the spec, whichever is
appropriate. Since your package seems to use pure python module, remove the
sitearch macro.

2. You have the following lines:
# Remove files we install with %%doc
rm -f %{buildroot}%{_datadir}/doc/arista/{AUTHORS,LICENSE,README.md}

But I don't see where in %doc these files are re-added. Admittedly I having
tried building the package but that still looks strange.

It's better to use a packaging trick I learned. At the end of install do
something like this:

# Move documentation so it can be installed in the right place
rm -rf _tmpdoc && mkdir _tmpdoc
mv %{buildroot}%{_datadir}/doc/%{name}/* _tmpdoc/

Then in %files update your %doc to:

%doc _tmpdoc/*

3. Remove "rm -rf $RPM_BUILD_ROOT" in %install as it is no longer needed.
   Remove %defattr in %files as it is no longer needed.

4. Don't mix $RPM_BUILD_ROOT and %{buildroot}. Pick one. I like %{buildroot}
but the only requirement is you stick with one or the other.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.