[Bug 1999] Review Request: wl-kmod - Kernel module for Broadcom wireless devices

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1999





--- Comment #5 from Tim Lauridsen <tla at rasmil.dk>  2011-10-26 19:49:01 ---
(In reply to comment #4)
> (In reply to comment #3)
> Thanks! Done!
> 
> One question: as you mentioned in your review comments, this version is
> not the very last one (Broadcom published the last one yesterday
> 25/10/2011). What should I do to be the most "upstream" as possible?
> Open a new review for the upstream version or wait for this one to be
> accomplished and upgrade to the upstream version after? Excuse me for
> such a question, but I'm not already very familiar with these
> procedures.
> 

The review is the package to be included (again) to rpmfusion, you can 
upgrade to a later version now or later without needing a new review.
But maybe you should release this one first and the update to the lastest
upstream later. This version works great and a new upstream version might need
some extra work, you need to review that the current patches are still needed
and is working with the lastest upstream.

> One more question, the spec file contains actually this directive
> 
> %define buildforkernels newest
> 
> But to build the akmod-wl package this one must be set to:
> 
> %define buildforkernels current
> 
> How do I should set it to meet the akmods rpmfusion standards as this
> package provides a new version of the Broadcom drivers?

I don't know that, i'm not a akmod/kmod expert, try asking on the mailing list
maybe look in other akmod in rpmfusion.

> 
> SPEC: http://dl.dropbox.com/u/25699833/rpmfusion/wl-kmod/wl-kmod.spec 
> SRPMS:
> http://dl.dropbox.com/u/25699833/rpmfusion/wl-kmod/wl-kmod-5.100.82.38-1.fc15.src.rpm
> 
> $ rpmlint rpmbuild/SPECS/wl-kmod.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> 
> $ rpmlint rpmbuild/SRPMS/wl-kmod-5.100.82.38-1.fc15.src.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> $ rpmlint rpmbuild/RPMS/x86_64/kmod-wl-5.100.82.38-1.fc15.x86_64.rpm 
> kmod-wl.x86_64: W: spelling-error Summary(en_US) Metapackage -> Meta
> package, Meta-package, Prepackage
> kmod-wl.x86_64: W: no-documentation
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> $ rpmlint
> rpmbuild/RPMS/x86_64/kmod-wl-2.6.40.6-0.fc15.x86_64-5.100.82.38-1.fc15.x86_64.rpm
> kmod-wl-2.6.40.6-0.fc15.x86_64.x86_64: W: summary-not-capitalized C wl
> kernel module(s) for 2.6.40.6-0.fc15.x86_64
> kmod-wl-2.6.40.6-0.fc15.x86_64.x86_64: W:
> unstripped-binary-or-object /lib/modules/2.6.40.6-0.fc15.x86_64/extra/wl/wl.ko
> kmod-wl-2.6.40.6-0.fc15.x86_64.x86_64: W: no-documentation
> kmod-wl-2.6.40.6-0.fc15.x86_64.x86_64: E:
> kernel-modules-not-in-kernel-packages
> /lib/modules/2.6.40.6-0.fc15.x86_64/extra/wl/wl.ko
> kmod-wl-2.6.40.6-0.fc15.x86_64.x86_64: E:
> kernel-modules-not-in-kernel-packages
> /lib/modules/2.6.40.6-0.fc15.x86_64/extra/wl
> 1 packages and 0 specfiles checked; 2 errors, 3 warnings.
> 
> $ rpmlint
> rpmbuild/RPMS/x86_64/wl-kmod-debuginfo-5.100.82.38-1.fc15.x86_64.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 

Dont see any problems here, Fedora don't allow kernel module packages, so the
rpmlint can give some strange messages on kernel module packages.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.