[Bug 1901] Review request: bino - 3D video player

[Michael Schwendt]

On Fri,  2 Sep 2011 18:40:41 +0200, RFB (RPM) wrote:

> http://bugzilla.rpmfusion.org/show_bug.cgi?id=1901

> --- Comment #2 from Richard  hobbes1069 gmail com   2011-09-02 18:40:41 ---
> The spec file looks pretty good overall. A couple of things I would change.
> 
> 1. You don't need "%defattr(..." in %files anymore.
> 
> 2. I would use this trick to get all the documentation into one directory:
> 
> In %install:
> mkdir _tmpdoc

rm -rf _tmpdoc ; mkdir _tmpdoc

to restart with an empty _tmpdoc dir, e.g. for --short-circuit installs.

> mv %{buildroot}%{_datadir}/doc/%{name}/* _tmpdoc/
> rm -rf %{buildroot}%{_datadir}/doc
> 
> In %files:
> %doc AUTHORS COPYING ChangeLog README _tmpdoc/*

-- 
Fedora release 16 (Verne) - Linux 3.1.0-0.rc4.git0.0.fc16.x86_64
loadavg: 0.16 0.20 0.22