ZSNES FTBFS

[Ralf Corsepius]

On 09/04/2011 04:39 PM, Andrea Musuruane wrote:
> Hi,
>      I was going to update ZSNES to explicitly requires pulseaudio-libs
> (BZ #1926) and I found out that ZSNES doesn't compile with gcc 4.6.0
> (F15+).
>
> The buildlog is here (for devel):
> http://buildsys.rpmfusion.org/logs/fedora-development-rpmfusion_free/10187-zsnes-1.51-8.fc16/i686/build.log
>
> The problem seems to be that _FORTIFY_SOURCE breaks parsegen:
> https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/819774/comments/8
>
> Ubuntu *fixed* this disabling _FORTIFY_SOURCE for parsegen. This is
> not permitted in Fedora. Unluckily I don't have the necessary
> knowledge to fix this myself.
>
> Any help is appreciated.

 From what I can gather, parsegen is choking upon 
"-Wp,-D_FORTIFY_SOURCE" being passed as argument to it.

At least separating the call to the compiler from parsegen's code 
generation seems to fix the issue.

c.f. patch below.

This lets parsegen generate *.h+*.c's and causes the *.c's to be 
compiled by "normal compilation rules", instead of trying to compile 
them "on the fly" through "parsegen".

Ralf
-------------- next part --------------
diff -Naur zsnes_1_51/src/Makefile.in zsnes_1_51.hacked/src/Makefile.in
--- zsnes_1_51/src/Makefile.in	2007-01-24 21:54:12.000000000 +0100
+++ zsnes_1_51.hacked/src/Makefile.in	2011-09-05 04:35:09.297967796 +0200
@@ -94,8 +94,8 @@
 	@CC@ @CFLAGS@ -o $@ -c $<
 %.o: %.cpp
 	@CXX@ @CXXFLAGS@ -o $@ -c $<
-%.o %.h: %.psr $(PSR)
-	./$(PSR) @PSRFLAGS@ -gcc @CC@ -compile -flags "@CFLAGS@ -O1" -cheader $*.h -fname $* $*.o $<
+%.c %.h: %.psr $(PSR)
+	./$(PSR) @PSRFLAGS@ -cheader $*.h -fname $* $*.c $<
 
 default: main
 all: main tools