[Bug 1931] Review request: audacious-plugins-nonfree - Audacious media player plugins with non free dependencies

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1931


Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4




--- Comment #1 from Michael Schwendt <mschwendt at gmail.com>  2011-09-21 16:44:43 ---
> audacious-plugins-3.0.2-hardsid.patch

Doubtful patch. src/sid/xmms-sid.h says:

| /* HardSID-support is not working and is untested, thus we disable it here.
|  */
| #undef HAVE_HARDSID_BUILDER

This overrides config.h settings, and in turn, conditional code for HardSID
support is not compiled. Linking the harsid-builder lib is useless.

Further, the plugin's GUI pieces are #if'ed out because they have not been
ported to Audacious Preferences Widgets. This implies one cannot reconfigure
the plugin with the GUI, but only by editing Audacious' config file.

Apart from that, HardSID has been (or still is) a niche market soundcard that
can be populated with real SID chips. I can't resolve http://www.hardsid.com
currently. It could be down or gone. I don't know anything about the more
recent devices from that project, but the early ones have had timing issues
with critics claiming that they have had varying results compared with either
emulation or The Original sids.

[...]

Only slightly related, refer to 
http://lists.rpmfusion.org/pipermail/rpmfusion-developers/2011-September/010163.html
 for a comment on libsidplayfp, which I've been pointed at. It could be that
some projects will switch to it.

[...]

You could trim down the %description as it isn't necessary to describe
Audacious here, and that description is out-of-date anyway.

[...]

>        --disable-sse2 \

This option has been dropped.

[...]

You could conflict explicitly with the "audacious-plugins-sid" package.

[...]

Have built this successfully (x86_64), installed it, and it works for playing a
couple of test files in PSID v2 format. Don't have quick access to any PSID v3
files.

Dropping the hardsid patch and related spec sections is trivial and doesn't
need a re-review.

APPROVED


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.