[Bug 1936] Review request: LiVES - Formerly Linux, but now just the Video Editing System

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936


Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hobbes1069 at gmail.com




--- Comment #5 from Richard <hobbes1069 at gmail.com>  2011-09-26 15:46:52 ---
Some suggestions:

1. You don't need "lives_version". Just put the version in the Version: field
and you can use %{version} instead.

2. For your subpackages, I don't think you need things like "%{release}" in
"Release:" if you just leave it out it will be the same release as the main
package.

3. Don't use macros for common bash commands and utilities (rm, mv, make . It's
not necessary and hurts readability.

4. If you're not building for EL 5, you can drop "rm -rf %{buildroot}" from
%install, %defattr from %files, and "BuildRoot:" entirely.

I see you already removed %clean..

You can probably also drop the static libraries unless you already have plans
for something to use them that can't use the shared libraries. 

This is a quick 5 minute review so I don't have time to be thourogh, but I see
in you %files you're using a lot of %dir and then grabbing the files under that
dir on the next line. For example:

%dir %{_appdatadir}/themes
%{_appdatadir}/themes/*

could just be:

%{_appdatadir}/themes

which will grab the directory and everything under it.

Unless it causes a problem I think you could just do:

%{_appdatadir}

and then list any excludes under it (like the resources dir).

Richard


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.