[Bug 1943] Review request: Butt - Broadcast using this tool to Icecast or Shoutcast servers

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1943





--- Comment #4 from Andrea Musuruane <musuruan at gmail.com>  2011-09-27 14:38:20 ---
I had a quick look at your package. Some remarks:

* The changelog format is wrong:
"Changelog entries should provide a brief summary of the changes done to the
**package** between releases, including noting updating to a new version,
adding a patch, fixing other spec sections, note bugs fixed, and CVE's if any.
They must never simply contain an entire copy of the source CHANGELOG entries."
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

* Patches must have an upstream bug link or a comment:
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

* You must never patch the LICENSE file. Please ask upstream to fix it.

* Use desktop-file-install to install the desktop file (and therefore remove
the desktop-file-validate call):
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

* "BuildRequires: desktop-file-utils" is missing:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

* Have you tried to build this package with mock to verify 
BuildRequires?
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
https://fedoraproject.org/wiki/Projects/Mock

* About "./configure --prefix /usr". Isn't "%configure" working?

* Compilers used to build packages must honor the applicable compiler flags set
in the system rpm configuration:
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

* Summary can probably be shortened to "Broadcast to Icecast or Shoutcast
servers"

* Please use the same indentation:
Name: butt
Version:        0.1.12
[..]


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.