[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098

Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hobbes1069 at gmail.com

--- Comment #46 from Richard <hobbes1069 at gmail.com> 2012-04-05 15:12:03 CEST ---
(In reply to comment #45)
> Richard is the cmake guru here,  it seems. In one of the rpmfusion bugs (lost
> which one) you can find:

Thanks for the title but there's still a few others on RPM Fusion that know it
better than I :)


> I can help there. It looks like lib3ds-devel provides a pkgconf config file so
> something like this should work:
> 
> INCLUDE(FindPkgConfig)
> IF(USE_EXTERNAL_LIB3DS)
>        # The last argument may need to be lib3ds depending on the pkgconf
> config.
>        PKG_CHECK_MODULES(LIB3DS REQUIRED 3ds)
>        INCLUDE_DIRECTORIES(SYSTEM ${LIB3DS_INCLUDE_DIRS})
> ENDIF()

You really have two options here. If you want to send a patch upstream so you
don't have to maintain a patch forever then the above will work but you'll also
need to add the ELSE() condition to be acceptable upstream.

If you don't want to send it upstream (although I recommend you do, it will
make you're life easier in the long run) you could go with a minimal patch and
not mess with creating a new cmake option.


> Also, if you use the "option" as shown above you'll need to add that to you
> cmake options:
> %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
>        -DUSE_EXTERNAL_LIB3DS=TRUE \

The CMAKE_BUILD_TYPE should only be used if you're not getting the right build
flags. I'm not entirely sure what causes it but some packages try to build with
-O3 instead of -O2 which this option often fixes. Try building without the
option first and review your build log to see if the Fedora build flags are
being overridden.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.