[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #9 from Yajo <yajo.sk8 at gmail.com> 2012-04-06 19:24:42 CEST ---
Sorry for the delay.

(In reply to comment #3)
> A bunch of notes, I can do a full review later:
> [...]

Great help, thanks. I followed almost all of these, and your SRPM was of great
help. Just a few points:


> -You missing %post, %postun and %posttrans sections, which are required for
> desktop files with icons: (you can also see my SPRM below)
> https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files

Well, in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
says that is to do when 'an application installs icons into one of the
subdirectories in %{_datadir}/icons/', but that's not the case anymore. Seeing
your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous
condition is not fulfilled anymore. For that reason, I did not add those
scriptlets. Correct me if I'm wrong, please.


> By the way, kudos for the idea of getting the logo from the love file, it never
> occurred to me to do that.

Thanks. If you are thinking about packaging mari0, just mention that you can do
that there too. If not, I can package it.


> -Man pages are not vital for getting your package accepted, but it is suggested
> to look into making one.

I have not a clue about how to do this. I think this should be upstream work,
though.


> -To my knowledge %defattr(-, root, root) shouldn't be required, but to be
> honest I've never used it before.

I never really understood that. I used to put it because I saw it in a lot of
places. Anyway I removed that.

Here is my new SRPM: http://www.mediafire.com/?82odbzgh9jr8vc6

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.