[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

--- Comment #11 from Hans de Goede <j.w.r.degoede at gmail.com> 2012-04-07 09:48:01 CEST ---
(In reply to comment #10)
> (In reply to comment #9)

<snip>

> > > -You missing %post, %postun and %posttrans sections, which are required for
> > > desktop files with icons: (you can also see my SPRM below)
> > > https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_Files
> > 
> > Well, in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
> > says that is to do when 'an application installs icons into one of the
> > subdirectories in %{_datadir}/icons/', but that's not the case anymore. Seeing
> > your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous
> > condition is not fulfilled anymore. For that reason, I did not add those
> > scriptlets. Correct me if I'm wrong, please.
> 
> I believe pixmaps is also a part of the icon cache, thus it still needs to be
> updated, though I am not completely sure on this. I'll let you know when I
> figure that out. I guess I just always assumed it should be there without
> checking.

When you put an icon in /usr/share/pixmaps you don't need the icon cache
scriptlets. But the preferred locations for icons is under
/usr/share/icons/hicolor/apps/#x# so unless there is a specific reason not
to put the icon there, please put it there.

> > > -To my knowledge %defattr(-, root, root) shouldn't be required, but to be
> > > honest I've never used it before.
> > 
> > I never really understood that. I used to put it because I saw it in a lot of
> > places. Anyway I removed that.
> 
> I believe that is for compatibility with RedHat EL 5, and unless you plan to
> package for EPEL 5, it's pointless. As well I'm only currently maintaining love
> for Fedora 15, 16, 17, devel/rawhide

Right, %defattr is there in a lot of packages simply because it never got
removed
it is not needed anymore these days...

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.