[Bug 2237] Homer - live conferencing and more

RPM Fusion Bugzilla noreply at rpmfusion.org
Thu Apr 26 14:36:26 CEST 2012


https://bugzilla.rpmfusion.org/show_bug.cgi?id=2237

--- Comment #24 from Alec Leamas <leamas.alec at gmail.com> 2012-04-26 14:36:26 CEST ---
Now, much better! ;)

Still problems with the comment how to generate the source

# cd Homer-Conferencing
# git archive \\
#    --format=tar.gz \\
#    -o ../Homer-Conferencing-git3e38c5a.tar.gz \\
#    master
Source0:    %{name}-Conferencing-%{version}.git%{git_commit}.tar.gz

The argument to -o is not the same as Source0: i. e., it will not create the
same file. Also, and more important, checking out a branch will give a random
commit. What you want to do here is to checkout a specific commit, not a
branch. Checking out a branch also resets file modification dates;  ee don't
want that.

Besides, why call the git source Home-Conferencing-* when upstream source is
named Homer-Source-*?

My proposal:
# git archive --format=tar.gz -o ../%%{SOURCE0}  %%{git_commit}
Source0:    %{name}-Source-%{version}.git%{git_commit}.tar.gz

I suggest that you leave this as-is waiting for a complete review.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the rpmfusion-developers mailing list