[Bug 2400] Review request: xorg-x11-drv-catalyst-legacy - AMD's proprietary driver for ATI legacy graphic cards

Wed Aug 22 20:51:18 CEST 2012

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2400

--- Comment #7 from leigh scott <leigh123linux at gmail.com> 2012-08-22 20:51:18 CEST ---
(In reply to comment #6)
> Hi Leigh,
> 
> sorry its taken so long to get back to this - work unexpectedly dumped an
> all-nighter/all-weekender on me.
> 
> Just running rpmlint on the packages, a lot of warnings/errors but most can be
> ignored given the nature of the package. I've stripped some duplicates. If put
> a star next to the ones that I'd like you to comment on (please forgive any
> driver packaging ignorance I may have in advance):
> 
> xorg-x11-drv-catalyst-legacy.src: W: spelling-error Summary(en_US) AMD's ->
> AM's, AD's, MD's
>  * xorg-x11-drv-catalyst-legacy.src: W: invalid-url URL:
> http://www.ati.com/support/drivers/linux/radeon-linux.html HTTP Error 400: Bad
> Request

I will change this to http://support.amd.com/us/Pages/AMDSupportHub.aspx

> xorg-x11-drv-catalyst-legacy.src:243: E: hardcoded-library-path in
> %{_prefix}/lib
> xorg-x11-drv-catalyst-legacy.src:244: E: hardcoded-library-path in
> %{_prefix}/lib
> xorg-x11-drv-catalyst-legacy.src:245: E: hardcoded-library-path in
> %{_prefix}/lib/libAMDXvBA.cap
> * xorg-x11-drv-catalyst-legacy.src:251: W: macro-in-comment %{version}
> %%{version}

I fix this

> xorg-x11-drv-catalyst-legacy.src:370: E: hardcoded-library-path in
> %{_prefix}/lib/libAMDXvBA.cap
> xorg-x11-drv-catalyst-legacy.x86_64: W: spelling-error Summary(en_US) AMD's ->
> AM's, AD's, MD's
> xorg-x11-drv-catalyst-legacy.x86_64: W: invalid-url URL:
> http://www.ati.com/support/drivers/linux/radeon-linux.html HTTP Error 400: Bad
> Request
> * xorg-x11-drv-catalyst-legacy.x86_64: W: obsolete-not-provided
> catalyst-legacy-kmod

This is how we obsolete the old kmod module.

> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/bin/fgl_glxgears
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/lib64/xorg/modules/amdxmm.so
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/sbin/clinfo
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/sbin/amdnotifyui
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/sbin/atieventsd
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/lib64/xorg/modules/linux/libfglrxdrm.so
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/bin/atiodcli
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/bin/atiode
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/bin/amdcccle
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/lib64/xorg/modules/drivers/fglrx_drv.so
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/bin/aticonfig
> xorg-x11-drv-catalyst-legacy.x86_64: W: unstripped-binary-or-object
> /usr/bin/fglrxinfo
> xorg-x11-drv-catalyst-legacy.x86_64: W: conffile-without-noreplace-flag
> /etc/X11/xorg.conf.d/01-catalyst-legacy-videodriver.conf
> xorg-x11-drv-catalyst-legacy.x86_64: W: conffile-without-noreplace-flag
> /etc/OpenCL/vendors/amdocl64.icd
> xorg-x11-drv-catalyst-legacy.x86_64: W: conffile-without-noreplace-flag
> /etc/acpi/actions/ati-powermode.sh
> xorg-x11-drv-catalyst-legacy.x86_64: W: conffile-without-noreplace-flag
> /etc/X11/xorg.conf.d/00-catalyst-legacy-modulepath.conf
> xorg-x11-drv-catalyst-legacy.x86_64: W: conffile-without-noreplace-flag
> /etc/ati/authatieventsd.sh
> xorg-x11-drv-catalyst-legacy.x86_64: W: non-conffile-in-etc
> /etc/ati/amdpcsdb.default
> xorg-x11-drv-catalyst-legacy.x86_64: W: non-conffile-in-etc
> /etc/ati/logo.xbm.example
> * xorg-x11-drv-catalyst-legacy.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/amdcccle/ccc_copyrights.txt

I will fix

> xorg-x11-drv-catalyst-legacy.x86_64: W: non-conffile-in-etc /etc/ati/control
> * xorg-x11-drv-catalyst-legacy.x86_64: E: executable-marked-as-config-file
> /etc/acpi/actions/ati-powermode.sh

I'm not sure why, perhaps Stewart Adam's could explain it as it's deliberate.

install -D -p -m 0755 %{SOURCE5}
$RPM_BUILD_ROOT%{_sysconfdir}/acpi/actions/ati-powermode.sh

> xorg-x11-drv-catalyst-legacy.x86_64: W: non-conffile-in-etc /etc/ati/atiogl.xml
> xorg-x11-drv-catalyst-legacy.x86_64: W: non-conffile-in-etc
> /etc/ati/logo_mask.xbm.example
> * xorg-x11-drv-catalyst-legacy.x86_64: E: executable-marked-as-config-file
> /etc/ati/authatieventsd.sh

I'm not sure why, perhaps Stewart Adam's could explain it as it's deliberate.

chmod 755 $RPM_BUILD_ROOT/%{_sysconfdir}/ati/*.sh

> xorg-x11-drv-catalyst-legacy.x86_64: W: non-conffile-in-etc /etc/ati/signature
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary amdxdg-su
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary amdcccle
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary fgl_glxgears
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary atiode
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary
> amdupdaterandrconfig
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary amdnotifyui
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary atiodcli
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary
> atigetsysteminfo.sh
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary aticonfig
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary fglrxinfo
> xorg-x11-drv-catalyst-legacy.x86_64: W: no-manual-page-for-binary clinfo
> xorg-x11-drv-catalyst-legacy.x86_64: W: service-default-enabled
> /etc/rc.d/init.d/atieventsd
> * xorg-x11-drv-catalyst-legacy.x86_64: W: incoherent-init-script-name
> atieventsd ('xorg-x11-drv-catalyst-legacy', 'xorg-x11-drv-catalyst-legacyd')

I'm going to ignore this warning as it's wrong.

> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libatiadlxx.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libaticalrt.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libamdocl64.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libOpenCL.so.1
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libfglrx_dm.so.1.0
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libatiuki.so.1.0
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: unstripped-binary-or-object
> /usr/lib64/catalyst-legacy/libaticalcl.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: conffile-without-noreplace-flag
> /etc/ld.so.conf.d/catalyst-legacy-lib64.conf
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: no-documentation
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/catalyst-legacy/libXvBAW.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/catalyst-legacy/libfglrx_dm.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/catalyst-legacy/libGL.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/catalyst-legacy/libAMDXvBA.so
> xorg-x11-drv-catalyst-legacy-libs.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/catalyst-legacy/libatiuki.so
> 
> I'm assuming the conffile no replace is intentional?
> 
> cheers

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.