[Bug 2161] Review request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

RPM Fusion Bugzilla noreply at rpmfusion.org
Wed Feb 8 21:53:32 CET 2012


https://bugzilla.rpmfusion.org/show_bug.cgi?id=2161

--- Comment #16 from Alec Leamas <leamas.alec at gmail.com> 2012-02-08 21:53:32 CET ---
Looks fine to me, without doing a complete review. Open issues are about
comments:

- Regression: the commands used to create the source are missing again. When
you add them, make sure that remove the .svn directories from source; either by
svn -export or by using --exclude in the tar command. See
http://fedoraproject.org/wiki/Common_Rpmlint_issues#version-control-internal-file
- The source situation is perhaps better explained by a commented, correct
Source: line IMHO.

If you want, I can make a more complete review. And I would be extremely happy
if you could review "my" bug 2140 later, but there are updates pending  for
that right now.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the rpmfusion-developers mailing list