[Bug 2150] Review request: geom - SALOME Geometry Module

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2150

--- Comment #16 from Richard <hobbes1069 at gmail.com> 2012-02-15 16:48:02 CET ---
Ok, first the good news. Most everything looks good. 

Now the bad news...

Most people don't both running rpmlint on the installed package and it's not a
packaging guideline requirement (but it should be). I found some linkage
problems with the library. I'll attach the full rpmlint output because it's too
big to post here (which usually isn't a good sign :)

Basically you have two major things going on. Both are fixable.

The first is "undefined-non-weak-symbol" which rpmlint describes as:
$ rpmlint -I undefined-non-weak-symbol
undefined-non-weak-symbol:
The binary contains undefined non-weak symbols.  This may indicate improper
linkage; check that the binary has been linked as expected.

Basically, it has symbols for libraries it's not linked to.

The other, easier one, is: "unused-direct-shlib-dependency"

The most direct method is to add "-Wl,--as-needed" to your linker flags, a la:
LDFLAGS="-Wl,--as-needed";export LDFLAGS

just before your cmake command.

If you have trouble fixing the first, let me know. I'll see if I can help.
Also, once fixed, you'll need to send the patch upstream.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.