[Bug 2161] Review request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2161

--- Comment #24 from Jeremy Newton <alexjnewt at hotmail.com> 2012-02-19 18:30:47 CET ---
(In reply to comment #23)
> Nit-pickinng, indeed. Since my point is that the copyright contains something
> valuable  I'll do:
> 
> %prep
> cp debian-upstream/copyright .
> rm -rf debian-ujpstream
> 
> %files
> %doc copyright

Actually I'm a little confused as of why I put that note in there in the first
place, as the copyright file is a little inapplicable. It's mostly for debian
purposes, a rehash of the AUTHORS file, and to help clear up the confusion of
why psemu_plugin_defs.h is public domain despite it's licensing header. It
seems that the pcsxr team removed this header a long time ago, so adding the
copyright file may make things even more confusion haha.
Anyway, I think it would be best just not to include any reference to this
file, as the COPYING file, the AUTHORS file and the license breakdown in the
spec provide all the useful information in a more applicable fashion.


Anyway, here's the new spec and SRPM:
SPEC:
http://dl.dropbox.com/u/42480493/pcsxr.spec
SPRM:
http://dl.dropbox.com/u/42480493/pcsxr-1.9.92-1.20120219svn75156.fc16.src.rpm

Notes:
* All but 2 FSF-address warnings have been fixed, I have re-opened my bug
report to let the dev's know that they missed these two files.

* As well compiling natively and on mock, i686 and x86-64, does not give me the
executable-stack warning what so ever, so I can't say what is causing this. I
would think it could be ASM as pcsxr does include a small amount of ASM code,
but I don't even know what file is giving the error.

* As for the opengl issue, it seems I was wrong about that. After doing some
testing myself, the issue is only a minor resolution bug that occurs on both
architectures. I have reported the bug upstream and enabled opengl on both
arch's.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.