[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098

--- Comment #21 from Alec Leamas <leamas.alec at gmail.com> 2012-02-21 20:33:39 CET ---
Let's forget this sad koji story...

> > 3.  Source/Core/Core/Src/IPC_HLE contains the kernel headers hci.h
> >     and l2cap.h, which seems like a bad bundling.
> 
> Hmmm that seem problematic... I may have to contact upstream about this.
Talking to upstream is of course  never wrong. In the meantime, can't you just
remove these and replace with symlinks to system headers in %prep?


[cut]
> Unfortunately there is no upstream tarball to my knowledge, so that is why I
> included a git command. What would you suggest with the %prep section? I'm
> using a spin as suggested by Julian in comment 3:
I would interpret Julians "spin" differently, but I'm Swede, you know... In the
word "spin" I would understand a git clone at a given state, without adding
anything I didn't get from the git repo. Those things (desktop, icons) still
are handled better separately, perhaps in a small tar archive (Source1:) which
is unpacked in  %prep. But of course it's a possible way to mix it in a source
combo. But you then need to document it, and that can be messy. One way is to
write a script which creates the combo, and adding that script to the srpm.
Then the comment could be straight-forward.

Git is no problem at all. But you need to show to complete sequence of commands
leading up to the tarball. Usually something like

git clone whatever
cd whatever; git reset --hard commit; cd ..
tar czf whatever.tar.gz --exclude=.git whatever

but obviously  something else in your case, The overall requirement on the
source comment is that you should be able to create you own source from
upstream using it.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.