Updating mplayer: how about using bundled ffmpeg?

[Julian Sikorski]

W dniu 27.02.2012 16:00, Sérgio Basto pisze:
> On Mon, 2012-02-27 at 15:47 +0100, Julian Sikorski wrote: 
>> W dniu 27.02.2012 15:43, Sérgio Basto pisze:
>>> On Mon, 2012-02-27 at 14:10 +0100, Julian Sikorski wrote: 
>>>> W dniu 27.02.2012 13:54, Julian Sikorski pisze:
>>>>> W dniu 27.02.2012 13:20, Ralf Corsepius pisze:
>>>>>> On 02/27/2012 12:40 PM, Julian Sikorski wrote:
>>>>>>> W dniu 27.02.2012 07:16, Ralf Corsepius pisze:
>>>>>>>> On 02/27/2012 02:55 AM, Kevin Kofler wrote:
>>>>>>>>> Julian Sikorski wrote:
>>>>>>>>>> I was trying to update mplayer and most of the problems I am having
>>>>>>>>>> are
>>>>>>>>>> due to using shared ffmpeg, which is discouraged and unsupported by
>>>>>>>>>> upstream. The latest error is:
>>>>>>>>>>
>>>>>>>>>> libmpdemux/mp_taglists.c:27:34: fatal error:
>>>>>>>>>> libavformat/internal.h: No
>>>>>>>>>> such file or directory
>>>>>>>>>>
>>>>>>>>>> when trying to build 20120204 snapshot. Looking at the svn log,
>>>>>>>>>> this was
>>>>>>>>>> added in revision 34243 (from 20111023). This all seems to indicate
>>>>>>>>>> that
>>>>>>>>>> trying to use system ffmpeg is an uphill battle which will always
>>>>>>>>>> going
>>>>>>>>>> to keep our mplayer behind, as well as piss upstream off when we come
>>>>>>>>>> asking for help.
>>>>>>>>>
>>>>>>>>> I don't think bundling is an acceptable solution, especially with
>>>>>>>>> something
>>>>>>>>> like FFmpeg which has security updates quite frequently.
>>>>>>>>
>>>>>>>> +1
>>>>>>>>
>>>>>>>> Ralf
>>>>>>>>
>>>>>>>>
>>>>>>> Well, I tried building it using system ffmpeg and have not succeeded
>>>>>>> yet. I am really not sure if going against upstream is the smart choice
>>>>>>> here, given that, at least in my case, I am going to need them to fix
>>>>>>> bugs.
>>>>>>> Help in unbundling ffmpeg is welcome.
>>>>>>
>>>>>> Where can I find your *.specs/*srpms?
>>>>>>
>>>>>> Ralf
>>>>>>
>>>>>>
>>>>> Here is the spec in the shared ffmpeg version - it fails to build due to
>>>>> internal.h inclusion.
>>>>> You need to comment out the gui building - I have not figured out why it
>>>>> fails yet.
>>>>>
>>>>> https://share.ols.inode.at/72IFK6BJDE97LBN2C2AP6PEJ7XMW5F7AHPQ3V2L0
>>>>>
>>>>> Julian
>>>>>
>>>>>
>>>> To be more verbose, gui fails to build due to ff_png not being returned
>>>> by objdump on libavcodec.so. I have no idea why, since according to
>>>> rpmfusion build logs both ffmpeg-0.8.9-1.fc17 and ffmpeg-0.10-1.fc18
>>>> were built with png support.
>>>
>>> this look like issues with new version of libpng on F-17 , try add
>>> png-devel in BuildRequires (just a guesse in dark) .
>>>   
>>>>
>>>> Julian
>>>>
>>>
>> I just changed the way ffmpeg support is queried since it was patched
>> anyway and now everything builds. Please test as I do not have a F-17
>> machine set up.
> 
> 
> I will test it on F16 , 
> but where the all the things, ffmpeg, mplayer etc src.rpm ? 
> 
> how I can view list of yours packages in share.ols.inode.at ? , by
> date ? 
There is only mplayer src.rpm there:
https://share.ols.inode.at/JWTTUS3OVG1C0CJ3QQCHDQKFW1BG3J9MF2F0UIYP
One cannot I am afraid. This hosting is quite bad but that's all I have
given that using fedorapeople for mplayer is a no-go.
ffmpeg and x264 I used came from rpmfusion plague results repo. Testing
on F-16 might be hard since you need to update the whole multimedia stack.

> 
> we need to see what you change (in patches) to approve and commit in a
> 2nd phase.
> 
> So a complete list of what is new or altered patches is also welcome . 

Output of cvs diff -u is attached - I was working on mplayer/F-17 since
kwizart deleted the spec from devel.

> 
> Thanks, 
> 
>> Julian
>>
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.diff
Type: text/x-patch
Size: 21557 bytes
Desc: not available
Url : http://lists.rpmfusion.org/pipermail/rpmfusion-developers/attachments/20120227/644bb7c4/mplayer-0001.bin